This repository was archived by the owner on Nov 30, 2022. It is now read-only.
Fix Dockerfile importlib.metadata.PackageNotFoundError: fidesops [#23]#24
Closed
pattisdr wants to merge 1 commit into
Closed
Fix Dockerfile importlib.metadata.PackageNotFoundError: fidesops [#23]#24pattisdr wants to merge 1 commit into
pattisdr wants to merge 1 commit into
Conversation
…docker-compose is bind mounting a volume to /fidesops, it is overriding the /fideops directory and my installed fidesops can't be found.
eastandwestwind
approved these changes
Nov 8, 2021
Contributor
eastandwestwind
left a comment
There was a problem hiding this comment.
Nice catch @pattisdr! 💯
Contributor
Author
|
Going to close, as I made this PR from my fork, which doesn't have CI enabled, and reopen - |
Contributor
Author
|
Reopened here: #48 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix
fidesopsnot getting installed withmake server:The culprit appears to be the bind mount in
docker-compose.yml:Changes
Set the working directory to
fidesopsafter it installed. It seems likedocker-composeis bind mounting a local directory to/fidesopswhich is useful for reloading, but then we can't find the package source when we're trying to install.Ticket
Fixes #23