This repository was archived by the owner on Nov 30, 2022. It is now read-only.
Add package directory config, include migrations in the PyPI package #566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for manual configuration of a path to the package's `src/` directory. This is necessary to start the fidesops server when importing fidesops into fidesops-plus.
Also exlude `pycache` files.
PSalant726
added
enhancement
PSalant726
force-pushed
the
add-package-dir-config
branch
from
11b6434 to
8dc4447
Compare
sanders41
approved these changes
May 26, 2022
Contributor
sanders41
left a comment
sanders41
left a comment
There was a problem hiding this comment.
I couple of suggestions, but not blockers.
If you make these changes you only need to pass the path when you call init_db if the path is different than the path in the config.
PSalant726
force-pushed
the
add-package-dir-config
branch
from
e5414a2 to
a11bba8
Compare
PSalant726
force-pushed
the
add-package-dir-config
branch
from
a11bba8 to
b00cea1
Compare
sanders41
approved these changes
May 26, 2022
This was referenced Jun 2, 2022
sanders41
pushed a commit
that referenced
this pull request
Sep 22, 2022
…566) * Add a `package` config section Allows for manual configuration of a path to the package's `src/` directory. This is necessary to start the fidesops server when importing fidesops into fidesops-plus. * Include migrations in the PyPI package Also exlude `pycache` files. * Check for a `/fidesops` path basename * Update `CHANGELOG.md` * Include required `init_db` argument everywhere * Resolve build errors * Use a default `package_source_dir`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To support fidesops-plus, the database migrations must be included in the package published to PyPI. Additionally, it must be possible to manually specify the location of the installed package, so that the server will be able to start while importing fidesops from PyPI.
Changes
packageconfig section tofidesops.tomlChecklist
CHANGELOG.mdfileCHANGELOG.mdfile is being appended toUnreleasedsection in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checkslabel has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #565