-
Notifications
You must be signed in to change notification settings - Fork 16
Move the migrations package into the fidesops package
#620
Conversation
sanders41
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before merging this we will need to figure out the best way to handle open PRs that contain migrations. I know at least @pattisdr has a PR with a migration.
I guess a rebase and moving the migration file would work?
|
thanks for the heads-up on migrations Paul, since #591 was just merged, that's one migration that will need to be moved before this work is merged |
@sanders41 Yea exactly. In the past we've unfortunately just had to ask anyone with open PRs to rebase once a PR like this one is merged. @pattisdr I've merged in |
|
@PSalant726 All looks, but there is a merge conflict with CONTRIBUTING.md now. |
ec357fb to
ca95dc1
Compare
ca95dc1 to
dee651b
Compare
* Move the `migrations` package into the `fidesops` package (#620) * Move `/migrations` into core fidesops package Also moves the `alembic.ini` file. * Update references to the `/migrations` dir * Remove unused `PackageSettings` * Update `CHANGELOG.md` * Correct the path to `alembic.ini` * Correctly resolve config paths * Update `CHANGELOG.md` for patch release 1.5.3 (#623) * move migration Co-authored-by: Phil Salant <PSalant726@users.noreply.github.com>
* Move the `migrations` package into the `fidesops` package (#620) * Move `/migrations` into core fidesops package Also moves the `alembic.ini` file. * Update references to the `/migrations` dir * Remove unused `PackageSettings` * Update `CHANGELOG.md` * Correct the path to `alembic.ini` * Correctly resolve config paths * Update `CHANGELOG.md` for patch release 1.5.3 (#623) * move migration Co-authored-by: Phil Salant <PSalant726@users.noreply.github.com>
Purpose
When installing fidesops via PyPI, the
migrationspackage is installed outside of the fidesops package source tree, in a sibling directory of/fidesops. Currently there is no way to specify a path to DB migrations that exists outside of the/fidesopspackage source tree.The fidesops-plus repository requires access to the database migrations in order to start the API server.
Changes
migrationspackage into the corefidesopspackage/migrationsdirectoryPackageSettingsclassChecklist
CHANGELOG.mdfileCHANGELOG.mdfile is being appended toUnreleasedsection in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checkslabel has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #615