Skip to content
This repository was archived by the owner on Nov 30, 2022. It is now read-only.

Conversation

@sanders41
Copy link
Contributor

@sanders41 sanders41 commented Jun 10, 2022

Purpose

Upgrade mypy to the latest version. As part of the testing see if this would close #367 I updated Python to 3.9.13 in the Dockerfile. All tests passed with this upgrade so I left that in place also.

In order to get this through to fix the bug reports I had to add type: ignore in a lot of places for now. Where possible a proper fix should be done later. I will open a ticket for this.

Changes

  • Bump mypy from 0.812 to 0.961
  • Fix resulting mypy errors after upgrade
  • Bump Python from 3.9.6 to 3.9.13 in the Dockerfile

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #392 and #367

@TheAndrewJackson TheAndrewJackson merged commit 350a877 into main Jun 10, 2022
@TheAndrewJackson TheAndrewJackson deleted the mypy-upgrade branch June 10, 2022 16:07
sanders41 added a commit that referenced this pull request Sep 22, 2022
* Bump mypy from 0.812 to 0.961 and Python from 3.9.6 to 3.9.13

* Update CHANGELOG

* Remove unused import

Co-authored-by: Paul Sanders <pau@ethyca.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Misc DevOps] make mypy is failing on M1 Macs Fideops fails to start with TypeError.

3 participants