Skip to content
This repository was archived by the owner on Nov 30, 2022. It is now read-only.

Enable/Disable Datastores [Frontend] #693

Merged
TheAndrewJackson merged 3 commits into from
Jun 22, 2022
Merged

Enable/Disable Datastores [Frontend] #693

TheAndrewJackson merged 3 commits into from
Jun 22, 2022

Conversation

@pattisdr
Copy link
Contributor

@pattisdr pattisdr commented Jun 21, 2022 •
edited
Loading

❗ Dependent on #604: Merge that first

Purpose

Demonstrate that a user can disable a connected datastore from the Datastore Connection Management UI.
The datastore should remain visible from the UI, but UI should indicate that it is disabled.

Changes

  • Add a disable connection modal. If datastore is already disabled you have the option to enable it instead.
disable_datastore.mov

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #603

@pattisdr pattisdr marked this pull request as ready for review June 22, 2022 15:20
@pattisdr pattisdr force-pushed the fidesops_604_delete_datastore branch from 8ff5e3f to 51f4842 Compare June 22, 2022 17:19
Base automatically changed from fidesops_604_delete_datastore to main June 22, 2022 18:09
@pattisdr pattisdr force-pushed the fidesops_603_disable_datastore branch from d0246ea to 347742e Compare June 22, 2022 18:17
TheAndrewJackson
TheAndrewJackson approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@TheAndrewJackson TheAndrewJackson merged commit 2f63382 into main Jun 22, 2022
@TheAndrewJackson TheAndrewJackson deleted the fidesops_603_disable_datastore branch June 22, 2022 19:24
@pattisdr
Copy link
Contributor Author

pattisdr commented Jun 22, 2022

thanks for the review ⭐

sanders41 pushed a commit that referenced this pull request Sep 22, 2022
@pattisdr
Enable/Disable Datastores [Frontend] (#693)
14173b1 
* Add the ability to enable/disable a connectionconfig.

* Fix other location to prevent from closing modal while in progress.

* Update changelog.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@TheAndrewJackson TheAndrewJackson TheAndrewJackson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TheAndrewJackson TheAndrewJackson

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Datastore Management] Disable Datastore FRONTEND

3 participants

@pattisdr @TheAndrewJackson