This repository was archived by the owner on Nov 30, 2022. It is now read-only.
Search for PrivacyRequest based on hashed identity [#765]
#847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 25 commits
July 8, 2022 11:10
seanpreston
changed the title
PrivacyRequest based on hashed identity [#765]
TheAndrewJackson
approved these changes
Jul 12, 2022
Contributor
TheAndrewJackson
left a comment
TheAndrewJackson
left a comment
There was a problem hiding this comment.
LGTM. That's an interesting use of column to get back the ids. I haven't seen it before.
sanders41
pushed a commit
that referenced
this pull request
Sep 22, 2022
* adds identity fields to PrivacyRequest model * store identity data inside database * update changelog * add identities in test data command * store identities provided via the DRP creation endpoint * black + isort * store provided identity data in request creation from onetrust * remove deprecated migration * adds new provided identity table * use new provided identity table * add docstring, remove comment * update DRP privacy request creation to use ProvidedIdentity model * update identity creation in test data command * use persisted identity in OneTrust * update test to use persisted identity * isort update * use enums * optionally receive a salt in hash_value cmd * use a constant salt for provided identity hashing * remove import * use typehints * update typedef * use enum in dict * test for exact match search * added exact match search to request status api * import order * update CHANGELOG
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds exact match searching for identities.
Changes
identityquery param toget_request_statusAPI viewidentityparam, we hash the value withProvidedIdentity.hash_value(...)then search theProvidedIdentitytable for a matching hashed valueProvidedIdentity.privacy_request_idvalues to the mainquery.filter(...)search, so as to maintain compatibility with other filtersChecklist
CHANGELOG.mdfileCHANGELOG.mdfile is being appended toUnreleasedsection in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checkslabel has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #765