Skip to content
This repository was archived by the owner on Nov 30, 2022. It is now read-only.

Conversation

@chriscalhoun1974
Copy link
Contributor

@chriscalhoun1974 chriscalhoun1974 commented Jul 25, 2022

Purpose

Can reprocess from the BE, but need to provide ability to do so from FE.

Acceptance Criteria

Demonstrate that a user can retry an ERRORED subject request from the UI
retry should not be supported on other SR states (i.e. New, in progress, completed, etc)

Changes

Added Retry button which will only be rendered if the SR record has an Error status. Once the Retry button is clicked and the API endpoint (/privacy-request/{{privacy_request_id}}/retry) returns a successful response, the status is changed to In Processing and the Retry button is no longer rendered. If the API endpoint returns an exception, a toast message is rendered with the API exception message displayed.

Screen Shot 2022-07-25 at 1 07 01 PM
Screen Shot 2022-07-25 at 12 13 30 PM

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #863

@chriscalhoun1974 chriscalhoun1974 marked this pull request as ready for review July 25, 2022 17:49
Copy link
Contributor

@pattisdr pattisdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well @chriscalhoun1974, nice error handling

@pattisdr
Copy link
Contributor

Just the changelog conflict needed

@pattisdr
Copy link
Contributor

Looks good, just existing mssql failures, unrelated to this PR

@pattisdr pattisdr merged commit ef28958 into main Jul 26, 2022
@pattisdr pattisdr deleted the 863-retry-a-dsr branch July 26, 2022 14:01
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Retry a DSR (FE)

3 participants