This repository was archived by the owner on Jan 23, 2024. It is now read-only.
renaming cfg file in order to prevent rebuilding every time#6
Open
flaviofontana wants to merge 1 commit intoethz-asl:masterfrom
flaviofontana:master
Open
renaming cfg file in order to prevent rebuilding every time#6flaviofontana wants to merge 1 commit intoethz-asl:masterfrom flaviofontana:master
flaviofontana wants to merge 1 commit intoethz-asl:masterfrom
flaviofontana:master
Conversation
Contributor
|
Thanks @flaviofontana for this fix, I propose to change the header file instead of the cfg file. Do you agree with my solution? #7 |
Author
|
yeah sure but then make sure to adapt this line as well |
Contributor
|
Jup, all done here: #7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in dynamic reconfigure. If your cfg file does not have the same name as the header you are creating with (Driver.cfg->Driver.h), then the header file is reacreated every time and as a result the node builts every time you use catkin_make
Gruss
flavio