-
Notifications
You must be signed in to change notification settings - Fork 39
Modify autogen for decentralized repo model #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I've created a separate repository for C++ bindings with the decentralized ev3dev-lang as a submodule. It works! So, two things:
|
Because the primary function of ev3dev-lang is to hold the spec, having code at the top level seems like it could be confusing for some people. But I agree that the extra path qualification is annoying; when I get the chance I'll move the Also, as @dlech pointed out in #135, once we are comfortable with this structure and have used it for a bit I can move autogen into its own repo and make it an npm module. That way, you can just install the utility globally once and simply type the one- or two-word command name, without any path. |
|
@ddemidov I just added an |
|
Just tested, and it works! Can you make it executable though? Or I could add the commit to the PR myself if your OS does not allow it. |
Assuming you mean "can you |
|
Done. |
|
Thanks! You're fast! |
|
This looks good to me, so we probably need a 👍 from @rhempel. |
|
I just updated the readme in this branch -- can you take a look? The text hadn't been updated in a very long time, so I'm hoping this is more relevant. |
|
The README looks decent. One other thing I noticed is the definitions of autogen comments for various languages here. It seems we would need to update it in this repo for new languages. Is there a way to move this info into each language's |
Yes! Decent! The quality bar I strive for 😉
I debated this, but as I see it there are three major problems with doing it this way:
Obviously, none of those would prevent us from doing it this way; but it is a tradeoff that we have to consider. |
|
@rhempel Can you take a look at this? |
|
My instinct tells me to leave the autogen comment strings where they are and to NOT distribute them into each language's autogen-config.json - for the exact reasons that @WasabiFan mentions. This also leaves the door open for each language binding maintainer to use whatever method they choose to autogen the bindings - the thread that holds everything together is the At worst, every time we add a new language binding we need to add a new comment regex in one place - that won't happen often enough to be a problem. |
|
But overall yes - 👍 |
|
It sounds like we're in agreement that this is what we want in the repo -- should I merge it now, or would you like some time to get Python transitioned to using this system (create the config file and add the submodule)? |
|
I've created ev3dev/ev3dev-lang-python#101 that does the switching for python. |
|
I think this can be merged now that ev3dev/ev3dev-lang-python#101 is merged. |
Modify autogen for decentralized repo model
This is a first attempt at the changes discussed in #135.
I think this is completely functional, so I'm looking for feedback on the changes that were made and ideas for improving/modifying the new structure.
I haven't yet updated the README for autogen; I will remove this message when I do.
@ddemidov @rhempel