check lengths of maps and recurse over only one if it is necessary#87
Merged
evanphx merged 2 commits intoevanphx:masterfrom Aug 15, 2019
Merged
check lengths of maps and recurse over only one if it is necessary#87evanphx merged 2 commits intoevanphx:masterfrom
evanphx merged 2 commits intoevanphx:masterfrom
Conversation
Author
|
/cc @evanphx Whenever you have the time to look this over, it would be much appreciated. |
Owner
|
Thanks so much! Great catch! |
This was referenced Jun 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The matchesValue function, in the worst case, has exponential time complexity (for deeply nested maps). This fix should make things operate in time linear to the number of objects compared.
Tests added: I've added some benchmark tests to justify the change. The tests generate a number of nested maps which creates an exponential number of nested map objects, given some input
n. More precisely, the helper function generates 2^(n+1)-1 objects.We can see that with the original function, the growth does not increase linearly with the number of objects:
Which makes sense, since the matchesValue function is currently exponential for nested maps, since we recursively call matchesValue twice for each key. With the patch, the operation scales linearly to in the increased object count.