Skip to content

Forecast: add common parameter set#19474

Merged
andig merged 1 commit into
masterfrom
feat/fcst
Mar 6, 2025
Merged

Forecast: add common parameter set#19474
andig merged 1 commit into
masterfrom
feat/fcst

Conversation

@andig
Copy link
Copy Markdown
Member

@andig andig commented Mar 6, 2025

Downside: we can't determine the parameter order when mixing presets with custom parameters. az is custom since forecasts might disagree on how to treat southern direction.

@andig andig added the tariffs Specific tariff support label Mar 6, 2025
@andig andig requested a review from naltatis March 6, 2025 11:09
@andig andig marked this pull request as ready for review March 6, 2025 11:09
@naltatis
Copy link
Copy Markdown
Member

naltatis commented Mar 6, 2025

Yes, field ordering is a topic we need to address in the future. But here it's not really a problem.

Copy link
Copy Markdown
Member

@naltatis naltatis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andig andig merged commit b46962a into master Mar 6, 2025
@andig andig deleted the feat/fcst branch March 6, 2025 11:56
thecem pushed a commit to thecem/evcc that referenced this pull request Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tariffs Specific tariff support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants