Skip to content

sungrow-hybrid: fix reset to normal battery mode#19882

Merged
andig merged 4 commits into
evcc-io:masterfrom
hameno:master
Mar 25, 2025
Merged

sungrow-hybrid: fix reset to normal battery mode#19882
andig merged 4 commits into
evcc-io:masterfrom
hameno:master

Conversation

@hameno
Copy link
Copy Markdown
Contributor

@hameno hameno commented Mar 17, 2025

The previously used forced value does not work reliably on my SH5.0RT. I'm proposing using the initial implementation that I successfully tested locally.

@andig andig added the devices Specific device support label Mar 17, 2025
@andig
Copy link
Copy Markdown
Member

andig commented Mar 17, 2025

The go plugin has an inherent memory leak and should be avoided.

@hameno
Copy link
Copy Markdown
Contributor Author

hameno commented Mar 17, 2025

The go plugin has an inherent memory leak and should be avoided.

Any other suggestion on how to get the rated value?

@andig
Copy link
Copy Markdown
Member

andig commented Mar 19, 2025

Not really at this time. Either accept the leak (battery won't be switched that often) or live with manual configuration.

The previously used forced value does not work reliably on my SH5.0RT

Unclear why that should be since it would write exactly the same value? I'm not convinced that the fix does fix what you think it does.

@hameno
Copy link
Copy Markdown
Contributor Author

hameno commented Mar 19, 2025

It would not write the same value, the BDC rated power is 5kW, this always tries to write 10kW. My battery is a SBR096 which is only rated for 5kW

@andig
Copy link
Copy Markdown
Member

andig commented Mar 19, 2025

value: {{ .maxchargepower | int }} # W

It will write whatever you put into maxchargepower. Just set it to 5k?

@hameno
Copy link
Copy Markdown
Contributor Author

hameno commented Mar 19, 2025

value: {{ .maxchargepower | int }} # W

It will write whatever you put into maxchargepower. Just set it to 5k?

But that is only one of the cases here. And only after my change? Not sure I get your comment here. I specifically handle this existing advanced configuration option now and offer a safe default if not configured.

@andig
Copy link
Copy Markdown
Member

andig commented Mar 19, 2025

It would not write the same value, the BDC rated power is 5kW, this always tries to write 10kW.

I don't understand. Why would it do that if you configure 5k? Why is the auto detection/ Go required?

@hameno
Copy link
Copy Markdown
Contributor Author

hameno commented Mar 19, 2025

I'm very confused.
Before this change: always write 10kW
After this change: allow overriding this or have it based on the actual limits of the battery. I'm simply using the same code that is used in other points of this template.

@andig
Copy link
Copy Markdown
Member

andig commented Mar 19, 2025

Lets just do the override then, leave the auto option out.

The previously used forced value does not work reliably on my SH5.0RT.
Allow overriding the rated power value.
Comment thread templates/definition/meter/sungrow-hybrid.yaml Outdated
Comment thread templates/definition/meter/sungrow-hybrid.yaml Outdated
Comment thread templates/definition/meter/sungrow-hybrid.yaml Outdated
Co-authored-by: andig <cpuidle@gmail.com>
Comment thread templates/definition/meter/sungrow-hybrid.yaml Outdated
@andig
Copy link
Copy Markdown
Member

andig commented Mar 25, 2025

Bei maxchargepower sollte noch ein

usages: ["battery"]

eingefügt werden- in anderen Modi tut der Parameter ja nichts.

@andig andig merged commit bdd457b into evcc-io:master Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devices Specific device support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants