Skip to content

Add battery mode api#20455

Merged
andig merged 41 commits into
evcc-io:masterfrom
iseeberg79:feat/externalBatteryControl
Apr 11, 2025
Merged

Add battery mode api#20455
andig merged 41 commits into
evcc-io:masterfrom
iseeberg79:feat/externalBatteryControl

Conversation

@iseeberg79
Copy link
Copy Markdown
Contributor

@iseeberg79 iseeberg79 commented Apr 6, 2025 •
edited by andig
Loading

work in progress for feature

  • integrated in /api/state
  • set via HTTP/REST
  • set via MQTT
  • publication of the active external battery mode via MQTT

The externally set battery mode is valid for a fixed interval of 60s. After this period and no new external trigger, the external battery mode is invalid. The external mode is embedded in internal functions for calculating the battery modes for mains charge or hold.

At first glance, the user interface seems to be consistent with the externally set battery mode and the function is working as expected. Maybe it's confusing if gridchargelimit is set.

TODO

  • add reset api
  • publish ext mode for UI

Out of scope

  • api error if battery not configured

@iseeberg79 iseeberg79 marked this pull request as draft April 6, 2025 20:29
@iseeberg79 iseeberg79 changed the title Feat/external battery control add feature for external control of the battery mode Apr 7, 2025
@iseeberg79 iseeberg79 changed the title add feature for external control of the battery mode add external control of the battery mode Apr 7, 2025
@iseeberg79
Copy link
Copy Markdown
Contributor Author

iseeberg79 commented Apr 7, 2025

@andig what do you think about it?

@andig andig added the devices Specific device support label Apr 8, 2025
andig
andig reviewed Apr 9, 2025
View reviewed changes
Comment thread server/http_site_handler.go Outdated
andig
andig reviewed Apr 9, 2025
View reviewed changes
Comment thread core/site_api.go Outdated
@iseeberg79
Copy link
Copy Markdown
Contributor Author

iseeberg79 commented Apr 9, 2025

Schau mal bitte ob das für dich so ok wäre?

Moin, die Funktion steht im Vordergrund. Da ist eine gewisse coole Code-Evolution passiert. Ich erkenne noch die Idee ;-)

Heute Abend teste ich die Funktion mal durch! Vorweggenommen sieht das für mich sehr schlüssig aus.

Spannend, danke!

iseeberg79
iseeberg79 commented Apr 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@iseeberg79 iseeberg79 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mit den Anpassungen macht es per MQTT was es soll; die REST-API klappt auch

Comment thread core/site_api.go Outdated
Comment thread core/site_api.go Outdated
Comment thread core/site_api.go Outdated
Comment thread core/site_api.go Outdated
@naltatis
Copy link
Copy Markdown
Member

naltatis commented Apr 9, 2025

Wir sollten batteryModeExternal publishen um einen entsprechenden Hinweis in der UI anzeigen zu können.

@iseeberg79
Copy link
Copy Markdown
Contributor Author

iseeberg79 commented Apr 10, 2025

ich hab das publishing mal mit eingebaut, primär aber die Änderungen, die nötig sind, damit es robust ist. Die Sperren sind jetzt wirksam und nicht blockierend, da die watchdog-Schleife endet. Schaut mal, ob das so in Ordnung ist.

andig
andig reviewed Apr 10, 2025
View reviewed changes
Comment thread core/site_api.go Outdated
andig
andig requested changes Apr 10, 2025
View reviewed changes
Comment thread core/site_api.go Outdated
Comment thread core/site_api.go Outdated
Comment thread core/site_api.go Outdated
Comment thread core/site_api.go Outdated
Comment thread core/site_api.go Outdated
Comment thread core/site_api.go Outdated
Comment thread core/site_api.go Outdated
Comment thread core/site_api.go Outdated
@iseeberg79
Copy link
Copy Markdown
Contributor Author

iseeberg79 commented Apr 10, 2025

Schau' ich mir später an. Die Logs brauchte ich gestern zur Fehlersuche, waren nützlich - können aber natürlich raus

iseeberg79
iseeberg79 commented Apr 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@iseeberg79 iseeberg79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getestet, zurücksetzen per externem BatteryUnknown ohne Anpassung nicht stabil

Comment thread core/site_api.go Outdated
Comment thread core/site_api.go Outdated
Comment thread core/site_api.go
@iseeberg79 iseeberg79 requested a review from andig April 10, 2025 20:36
@iseeberg79
Copy link
Copy Markdown
Contributor Author

iseeberg79 commented Apr 11, 2025

Der aktuelle Stand passt! Lass' uns gerne abschließen.

@andig andig merged commit 7e9bccf into evcc-io:master Apr 11, 2025
6 checks passed
@andig andig mentioned this pull request Apr 11, 2025
Closed
@iseeberg79 iseeberg79 deleted the feat/externalBatteryControl branch April 11, 2025 19:03
@andig andig mentioned this pull request Apr 12, 2025
Merged
@iseeberg79 iseeberg79 mentioned this pull request Apr 12, 2025
Closed
@andig andig mentioned this pull request Apr 12, 2025
Closed
@WolfImBusch WolfImBusch mentioned this pull request Apr 12, 2025
Closed
@naltatis naltatis mentioned this pull request Apr 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@naltatis naltatis Awaiting requested review from naltatis

@andig andig Awaiting requested review from andig

Assignees

No one assigned

Labels

enhancement New feature or request needs documentation Triggers issue creation in evcc-io/docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iseeberg79 @andig @naltatis