Skip to content

RCT: add maxchargepower#21156

Merged
andig merged 5 commits into
evcc-io:masterfrom
Maschga:feat/rct-maxchargepower
May 10, 2025
Merged

RCT: add maxchargepower#21156
andig merged 5 commits into
evcc-io:masterfrom
Maschga:feat/rct-maxchargepower

Conversation

@Maschga
Copy link
Copy Markdown
Collaborator

@Maschga Maschga commented May 9, 2025

Refs #20451

  • ➕Add maxchargepower parameter to template

TODO:

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Maschga - I've reviewed your changes - here's some feedback:

  • Please resolve the TODO item in the PR description regarding a default value for maxchargepower; if no default is set and the parameter is omitted by users, the charging limit will become 0, changing from the previous hardcoded 10kW.
  • Consider renaming the maxchargepower function parameter in NewRCT to maxChargePower for consistency with Go's camelCase naming conventions for multi-word identifiers.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread templates/definition/meter/rct-power.yaml
Comment thread templates/definition/meter/rct-power.yaml Outdated
@andig andig added the devices Specific device support label May 9, 2025
@andig andig changed the title RCT: Add maxchargepower RCT: add maxchargepower May 9, 2025
@andig andig merged commit 48b0110 into evcc-io:master May 10, 2025
6 checks passed
@Maschga Maschga deleted the feat/rct-maxchargepower branch May 10, 2025 10:32
guido4096 pushed a commit to guido4096/evcc that referenced this pull request May 25, 2025
StarF666 pushed a commit to StarF666/evcc that referenced this pull request Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devices Specific device support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants