fix: vehicle plan publish fails on boot#26278
Closed
naltatis wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- If
site.coordinatorbeingnilis unexpected in normal operation, consider adding a debug or warning log in thenilcase so it's easier to spot misconfigured startup sequences rather than silently skipping publication. - You might also consider guarding the call to
publishVehiclesuntil aftersite.coordinatoris initialized, which would avoid needing thenilcheck here and make the initialization sequence more explicit.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- If `site.coordinator` being `nil` is unexpected in normal operation, consider adding a debug or warning log in the `nil` case so it's easier to spot misconfigured startup sequences rather than silently skipping publication.
- You might also consider guarding the call to `publishVehicles` until after `site.coordinator` is initialized, which would avoid needing the `nil` check here and make the initialization sequence more explicit.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Member
|
We should only merge when the root cause is clear. It isn‘t to me.
What should be racy? Don‘t think guessing helps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #26272
follow-up to #24423
Seems to be an issue when booting with db-configured vehicles. We changed publish behavior in #24423.
@andig I'm currently unable to create a reproducible failing test. Maybe race-condition. But we could merge this anyways.