Conversation
Contributor
There was a problem hiding this comment.
Sorry @andig, your pull request is larger than the review limit of 150000 diff characters
Member
Author
|
Failed aber :O |
Member
Looks like unit conversion issue. I'll check. |
Member
|
@andig maybe one step back. Whats the actual goal this PR tries to achieve? We have multiple things at play here. Contintinuous/Precondition values on loadpoint and vehicle level and also effective values combining both. |
Member
Author
|
An effective hat der PR noch nix geändert, das wäre aber der nächste Schritt. Alles möge über die neuen Keys laufen. |
Contributor
|
ich könnte den verbleibenden UI Umbau vorschlagen, wenn's hilfreich ist |
Member
Author
|
Wollten wir das noch ändern? Sonst mache ich hier zu. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #24423, depends on #26291.
TODO