GPIO: always use pull-up for logic input

[premultiply]

Open (not connected to GND) => high, true, active
Closed (connected to GND) => low, false, inactive

Use the NC contact of a connected relay.

The LPC limit (§14a EnWG) is active when the relay contact is open; for normal operation, the contact must be closed. => In the event of a fault (e.g. cable break), the limit is activated (fail safe).

[sourcery-ai]

Hey - I've left some high level feedback:

• Applying p.pin.PullUp() unconditionally for all GpioTypeRead pins changes existing behavior; consider making the pull-up configuration explicit in the plugin config so callers can still choose floating or pull-down inputs where required.
• If the underlying GPIO library distinguishes between setting pull mode before/after direction, double-check whether PullUp() should be called prior to Input() to avoid transient incorrect states during initialization.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Applying `p.pin.PullUp()` unconditionally for all `GpioTypeRead` pins changes existing behavior; consider making the pull-up configuration explicit in the plugin config so callers can still choose floating or pull-down inputs where required.
- If the underlying GPIO library distinguishes between setting pull mode before/after direction, double-check whether `PullUp()` should be called prior to `Input()` to avoid transient incorrect states during initialization.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[andig]

Not sure here. This config is not specifically LPC but GPIO in general. Should we instead make the "active" state (i.e. lo/hi) configurable and then during setup configure the inactive pull up/down accordingly?

[premultiply]

Should be pull-up in general for all simple logic inputs. This is a physical thing. It never gets anything worse but does not work without.
Some pins already include a fixed pull-up resistor.

Optional inverting the logic on software side is another topic.
Good idea but OT here.

[andig]

Optional inverting the logic on software side is another topic.

Thinking about this. Current logic is high-active, so it actually fits already.

[andig]

Build got stuck, restarted.