Tariff: add time-based grid fees#29766
Conversation
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new
ZoneSpectype is now shared between price zones and charge zones; consider renaming or separating the structs (e.g.PriceZoneSpec/ChargeZoneSpec) to avoid accidental cross‑use and make the semantics clearer at the call sites. - In
embed.effectiveCharges, you force timestamps toLocal()before resolving zones; if tariffs should respect the original location onts, it may be safer to rely onts.Location()or document that all tariff time logic is explicitly local-time based.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `ZoneSpec` type is now shared between price zones and charge zones; consider renaming or separating the structs (e.g. `PriceZoneSpec`/`ChargeZoneSpec`) to avoid accidental cross‑use and make the semantics clearer at the call sites.
- In `embed.effectiveCharges`, you force timestamps to `Local()` before resolving zones; if tariffs should respect the original location on `ts`, it may be safer to rely on `ts.Location()` or document that all tariff time logic is explicitly local-time based.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Not sure I undestand. This is basically a UI wrapper for the fixed tariff? |
|
Whats the scope of these fees: any import/export tariff? Only on on fixed tariff? |
This is the ability to enter time-based grid fees for "all" price tariffs, import and export context. In this process the fixed template also received the |
fixes #26164
Add ability to specify time-based (month, day, time) grid fees (e.g. for §14a Dynamische Netzentgelte). These can be combined with any price tariff.
chargesZonesto overwrite existingchargesfor tariffs (advanced)zonesfeaturefixedtariffchargesZonesis treated as a dynamic tariff (preferred by planner, unlock cheap grid charging for lp and battery, show chart preview, ...)Screenshot