Energyflow UI: names instead of placeholders#29918
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- By removing the
generic*Titlefallbacks, entries now depend solely ontitleorname; consider keeping a last-resort generic label (e.g. via a small helper) so the UI remains readable if a meter is misconfigured or lacks both fields. - Since
genericBatteryTitle,genericPvTitle, andgenericConsumerTitleare no longer used, you might also remove any related i18n keys if they are now dead to avoid confusion in the translation files.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- By removing the `generic*Title` fallbacks, entries now depend solely on `title` or `name`; consider keeping a last-resort generic label (e.g. via a small helper) so the UI remains readable if a meter is misconfigured or lacks both fields.
- Since `genericBatteryTitle`, `genericPvTitle`, and `genericConsumerTitle` are no longer used, you might also remove any related i18n keys if they are now dead to avoid confusion in the translation files.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #29846 we published the
namefield for all meters. This PR replaced the genericSolar system #1,Battery storage #1, ... entries for yaml configured meters and showsnameinstead. Establishing consistent naming between energyflow and history chart labels.before (yaml + ui)

after (yaml + ui)
