Skip to content

Energyflow UI: names instead of placeholders#29918

Merged
andig merged 1 commit into
masterfrom
feat/energyflow_placeholder
May 16, 2026
Merged

Energyflow UI: names instead of placeholders#29918
andig merged 1 commit into
masterfrom
feat/energyflow_placeholder

Conversation

@naltatis
Copy link
Copy Markdown
Member

@naltatis naltatis commented May 15, 2026

In #29846 we published the name field for all meters. This PR replaced the generic Solar system #1, Battery storage #1, ... entries for yaml configured meters and shows name instead. Establishing consistent naming between energyflow and history chart labels.

before (yaml + ui)
Bildschirmfoto 2026-05-15 um 21 18 14

after (yaml + ui)
Bildschirmfoto 2026-05-15 um 21 26 07

@naltatis naltatis added enhancement New feature or request ux User experience/ interface labels May 15, 2026
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • By removing the generic*Title fallbacks, entries now depend solely on title or name; consider keeping a last-resort generic label (e.g. via a small helper) so the UI remains readable if a meter is misconfigured or lacks both fields.
  • Since genericBatteryTitle, genericPvTitle, and genericConsumerTitle are no longer used, you might also remove any related i18n keys if they are now dead to avoid confusion in the translation files.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- By removing the `generic*Title` fallbacks, entries now depend solely on `title` or `name`; consider keeping a last-resort generic label (e.g. via a small helper) so the UI remains readable if a meter is misconfigured or lacks both fields.
- Since `genericBatteryTitle`, `genericPvTitle`, and `genericConsumerTitle` are no longer used, you might also remove any related i18n keys if they are now dead to avoid confusion in the translation files.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@andig andig merged commit e7a27e5 into master May 16, 2026
19 checks passed
@andig andig deleted the feat/energyflow_placeholder branch May 16, 2026 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request ux User experience/ interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants