Skip to content

[PATCH] EB-194544: Fix round in Python 3, Fix test_format_decimal_float_rounding_decimal_currency_usd_2 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gabrielf-eb wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[PATCH] EB-194544: Fix round in Python 3, Fix test_format_decimal_float_rounding_decimal_currency_usd_2 #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion currint/currency.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@
from decimal import Decimal


def python2round(f):
if round(f + 1) - round(f) != 1:
return f + abs(f) / f * Decimal('0.5')
return round(f)


@six.python_2_unicode_compatible
class Currency(object):
"""
Expand Down Expand Up @@ -62,7 +68,11 @@ def major_to_minor(self, value, force_round=False):
# Do the maths!
minor_value = value * self.divisor
if force_round:
minor_value = int(round(minor_value))
minor_value = (
int(round(minor_value))
if six.PY2
else int(python2round(minor_value))
)
if (minor_value != int(minor_value)):
raise ValueError(
"Cannot convert major amount %r to minor amount; would result in fractional amount of minor unit"
Expand Down