Skip to content

Conversation

@Jack12816
Copy link
Contributor

@Jack12816 Jack12816 commented Oct 19, 2020

First things first: Thank you very much for this great gem!


- What is it good for

With the small changes, we can not inherit the Tree::TreeNode class and build specialized trees (with extended functionality) and serialize and compare them correctly. Before the deserialization always forced the children to be of type Tree::TreeNode, which drops custom functionality.

- What I did

  • Added support for correct sub-class (de)serialization
  • Improved the comparability, so we allow pure Tree::TreeNode instances to be compared with compatible sub-classes
  • Added specs for both things

- A picture of a cute animal (not mandatory but encouraged)

Download

Signed-off-by: Hermann Mayer <hermann.mayer92@gmail.com>
@evolve75
Copy link
Owner

Thanks @Jack12816. This is very helpful. I have merged your changes and it
should appear in RubyTree R2.0.0.

@evolve75 evolve75 merged commit 54d2b39 into evolve75:master Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants