Various Rubocop fixes #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the _easy_ fixes to the code structure, and many were "auto-corrected" by Rubocop. The real changes (long and complex methods) will need more analysis of the code. Also fixed the `rdoc` generation to use the correct title and main file. Also added an auto-generated rubocop_todo config to defer fixes. This setup lets the issues be documented, while not becoming a nag.
This is to comply with the Ruby method naming convention for predicate methods (the ones ending with `?`). Rest of the code base has been updated to use the new method names. However, for backward compatibility, `aliases` with the old method names have been defined to the new names so that current client code can continue to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are mostly mechanical fixes to the code and should improve overall quality.
However, the code complexity issues still need to be resolved. The codebase has grown and some technical debt and cognitive load is now ripe for remediation.