Closed
Conversation
…llbacks and promises resultet in premature resolving of outer promise. Needs code-review.
Author
|
I want to discuss f0166f2, but to me it is the only sane way of resolving the promises recursively. I'm not 100% certain the implementation is totally correct, as I still try tro wrap my head around the mix of promises and callbacks going on. |
dufourgilles
reviewed
May 2, 2018
| self.codec = new S101Codec(); | ||
| self.status = "disconnected"; | ||
|
|
||
| const EventEmitter = require('events').EventEmitter |
Collaborator
There was a problem hiding this comment.
What's the purpose of removing all semi-colons ?
dufourgilles
reviewed
May 2, 2018
| var identifier = (tag & 0xC0) >> 6 | ||
| var value = (tag & 0x1F).toString() | ||
| var tagStr = tag.toString() | ||
| if (identifier === 0) { |
Collaborator
There was a problem hiding this comment.
our EVS eslint settings reject single quote.
Author
There was a problem hiding this comment.
Do you have lint settings? If you share them I'll use those.
dufourgilles
reviewed
May 2, 2018
|
|
||
|
|
||
| module.exports = {DeviceTree, DecodeBuffer}; | ||
| // function TreePath (path) { |
Collaborator
There was a problem hiding this comment.
do not leave commented code.
Author
|
Please disregard these PRs, they are corrupt. Will be back later if I have somthing that works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.