Skip to content

upgrade hackney to 3.x#1209

Open
acrogenesis wants to merge 1 commit intoex-aws:mainfrom
acrogenesis:main
Open

upgrade hackney to 3.x#1209
acrogenesis wants to merge 1 commit intoex-aws:mainfrom
acrogenesis:main

Conversation

@acrogenesis
Copy link
Copy Markdown

All 87 tests pass (1 skipped, same as before).
Bumped version to 2.7.0

  mix.exs: "~> 1.16" → "~> 3.2"

lib/ex_aws/request/hackney.ex:

  • Removed :with_body from opts — it's deprecated and ignored in 3.x (body is now
    always returned in the response tuple)
  • Removed the unreachable {:ok, status, headers} 3-tuple clause — in 3.x all
    responses return {:ok, status, headers, body}

dialyzer:

Total errors: 0, Skipped: 0, Unnecessary Skips: 0
done in 0m2.21s
done (passed successfully)


test "S3 uses bucket as host when both virtual_host and bucket_as_host are true" do
config = ExAws.Config.new(:s3) |> Map.put(:virtual_host, true) |> Map.put(:bucket_as_host, true)
config =
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes were made by mix format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant