Conversation
PR SummaryRelease summary
Other changes
Written by Cursor Bugbot for commit 0271876. This will update automatically on new commits. Configure here. |
|
Caution Review failedThe pull request is closed. WalkthroughRemoved a changeset file, added release entries to root and server changelogs, and bumped root and server package versions (root: 1.0.44 → 1.0.45; server: 0.2.46 → 0.2.47). Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 1 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @cruzdanilo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request facilitates an automated patch release for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request prepares a new release, version 1.0.45, for the @exactly/mobile package. The primary change included is to 'include installments fee in payment details'. My review of the underlying code for this change has uncovered a critical issue in src/components/activity/details/PaymentDetails.tsx. There is an inconsistency in how fees are calculated for multi-installment payments. This could result in displaying incorrect per-installment amounts to users, which is a significant issue for a financial application. I have detailed the problem and a suggested fix in a comment on the CHANGELOG.md file, as the affected code file is not part of this pull request's diff. It is highly recommended to address this before merging the release.
|
|
||
| ### Patch Changes | ||
|
|
||
| - [#617](https://github.com/exactly/exa/pull/617) [`b3153b8`](https://github.com/exactly/exa/commit/b3153b8ae245cc70a31b9c6ebcc9e60423e0245a) Thanks [@itofarina](https://github.com/itofarina)! - 🐛 include installments fee in payment details |
There was a problem hiding this comment.
There appears to be a potential bug in the implementation of the feature described in this changelog entry.
In src/components/activity/details/PaymentDetails.tsx, the calculation for the per-installment amount for multi-installment plans (item.mode > 1) seems inconsistent with the calculation for the total amount.
- The per-installment amount (lines 72-76) is derived from
item.usdAmount + (item as InstallmentsActivity).borrow.fee. - The total amount (lines 91-99) is calculated using
(item as InstallmentsActivity).borrow.installments.reduce((accumulator, installment) => accumulator + installment.fee, item.usdAmount).
The reduce method for the total amount is likely the correct source of truth for the sum of all fees. However, the per-installment calculation uses item.borrow.fee, which may not be the correct total fee. This can lead to displaying an incorrect amount for each installment.
This is a critical issue as it involves displaying incorrect financial data to the user.
To ensure consistency and correctness, the per-installment amount should be calculated based on the same total amount logic. Here is a suggested refactor:
// In PaymentDetails.tsx, for the item.mode > 1 case:
// Use the same logic as the total amount calculation to get the total fee.
const totalFee = (item as InstallmentsActivity).borrow.installments.reduce(
(accumulator, installment) => accumulator + installment.fee,
0,
);
// Then, in the JSX for per-installment amount:
{item.mode > 1 &&
((item.usdAmount + totalFee) / (item as InstallmentsActivity).borrow.installments.length).toFixed(2)}
// The total amount calculation is already correct.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #618 +/- ##
==========================================
+ Coverage 50.00% 54.24% +4.24%
==========================================
Files 43 50 +7
Lines 7236 7912 +676
Branches 540 644 +104
==========================================
+ Hits 3618 4292 +674
- Misses 3603 3605 +2
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Fix all issues with AI Agents 🤖
In @CHANGELOG.md:
- Line 7: The CHANGELOG entry starting with "- [#617] [`b3153b8`] Thanks
[@itofarina]! - 🐛 include installments fee in payment details" exceeds the
120-character limit; split or wrap this single long line into multiple shorter
lines (for example: keep the PR reference/link and commit hash on the first line
and wrap the contributor and description onto a second line, or break the
description after a natural boundary) so every line is under 120 characters
while preserving the exact text and links.
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (3)
.changeset/big-carrots-design.mdCHANGELOG.mdpackage.json
💤 Files with no reviewable changes (1)
- .changeset/big-carrots-design.md
🧰 Additional context used
📓 Path-based instructions (2)
**/*.md
📄 CodeRabbit inference engine (.cursor/rules/markdown.mdc)
**/*.md: Each markdown file must start with a single top-level heading (# heading 1)
Headings must be sequential (e.g.,#->##->###), do not skip levels
Do not end headings with punctuation (.,:,!,?)
Use a hyphen (-) for unordered list items in markdown
Sub-lists in markdown must be indented with a two-space offset
Always use unordered lists (-) instead of numbered lists (1.) in markdown
All code blocks must be fenced with backticks (```) and specify a language identifier
Useshor `bash` as the language identifier for shell commands in markdown code blocks
All code identifiers inside backticks or code fences must strictly follow casing rules defined in `style.mdc` (`camelCase` for variables, `PascalCase` for types, etc.)
All code comments must be lowercase
All lines in markdown files must be no longer than 120 characters
Surround all block-level elements (headings, lists, code blocks) with a single blank line in markdown
Do not add multiple consecutive blank lines in markdown files
No lines should have trailing whitespace in markdown files
Use asterisks (`word`) for italics and double asterisks (`word`) for bold in markdown
Provide descriptive titles for links in markdown instead of generic phrases like 'click here'Use proper sentence case for user-facing documentation in the
docs/directory
Files:
CHANGELOG.md
**/*.{mdc,md}
📄 CodeRabbit inference engine (.cursor/rules/style.mdc)
**/*.{mdc,md}: All narrative text in internal documentation prose (headings, paragraphs, list items, proper nouns, brand names) must be lowercase with no exceptions
When discussing code concepts in prose, use regular lowercase words and place correctly-cased identifiers inside backticks
Any identifier inside backticks or code fences must strictly follow the casing rules defined in the style guide and be treated as code, not prose
Files:
CHANGELOG.md
🧠 Learnings (1)
📚 Learning: 2025-12-23T19:56:56.405Z
Learnt from: CR
Repo: exactly/exa PR: 0
File: .cursor/rules/dev.mdc:0-0
Timestamp: 2025-12-23T19:56:56.405Z
Learning: Mobile app (exactly/mobile) uses React Native, Expo, Tamagui (UI), Expo Router (navigation), and TanStack Query (state management)
Applied to files:
package.json
🪛 LanguageTool
CHANGELOG.md
[typographical] ~7-~7: Consider using an em dash in dialogues and enumerations.
Context: ...ofarina](https://github.com/itofarina)! - 🐛 include installments fee in payment ...
(DASH_RULE)
🔇 Additional comments (1)
package.json (1)
3-3: Correct patch version bump.The version field is properly updated to 1.0.45, aligning with the changelog entry and PR objectives for a patch release.
cruzdanilo
force-pushed
the
changeset-release/main
branch
2 times, most recently
from
f344d88 to
df848fd
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
Fix all issues with AI Agents 🤖
In @CHANGELOG.md:
- Line 7: The changelog line containing "[#617] `b3153b8` Thanks [@itofarina]! -
🐛 include installments fee in payment details" exceeds 120 characters; split it
into multiple shorter markdown lines by wrapping after the PR/commit references
or contributor attribution (e.g., put the PR/commit references on one line and
the description/contributor on the next), or convert the long inline URLs to
reference-style links so each rendered line stays <=120 characters; update the
entry ensuring the visible text remains the same (keep "[#617]" and "`b3153b8`"
and the contributor mention) but break it into shorter lines to satisfy the
line-length rule.
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (3)
.changeset/big-carrots-design.mdCHANGELOG.mdpackage.json
💤 Files with no reviewable changes (1)
- .changeset/big-carrots-design.md
🧰 Additional context used
📓 Path-based instructions (2)
**/*.md
📄 CodeRabbit inference engine (.cursor/rules/markdown.mdc)
**/*.md: Each markdown file must start with a single top-level heading (# heading 1)
Headings must be sequential (e.g.,#->##->###), do not skip levels
Do not end headings with punctuation (.,:,!,?)
Use a hyphen (-) for unordered list items in markdown
Sub-lists in markdown must be indented with a two-space offset
Always use unordered lists (-) instead of numbered lists (1.) in markdown
All code blocks must be fenced with backticks (```) and specify a language identifier
Useshor `bash` as the language identifier for shell commands in markdown code blocks
All code identifiers inside backticks or code fences must strictly follow casing rules defined in `style.mdc` (`camelCase` for variables, `PascalCase` for types, etc.)
All code comments must be lowercase
All lines in markdown files must be no longer than 120 characters
Surround all block-level elements (headings, lists, code blocks) with a single blank line in markdown
Do not add multiple consecutive blank lines in markdown files
No lines should have trailing whitespace in markdown files
Use asterisks (`word`) for italics and double asterisks (`word`) for bold in markdown
Provide descriptive titles for links in markdown instead of generic phrases like 'click here'Use proper sentence case for user-facing documentation in the
docs/directory
Files:
CHANGELOG.md
**/*.{mdc,md}
📄 CodeRabbit inference engine (.cursor/rules/style.mdc)
**/*.{mdc,md}: All narrative text in internal documentation prose (headings, paragraphs, list items, proper nouns, brand names) must be lowercase with no exceptions
When discussing code concepts in prose, use regular lowercase words and place correctly-cased identifiers inside backticks
Any identifier inside backticks or code fences must strictly follow the casing rules defined in the style guide and be treated as code, not prose
Files:
CHANGELOG.md
🧠 Learnings (2)
📚 Learning: 2025-12-23T19:56:56.405Z
Learnt from: CR
Repo: exactly/exa PR: 0
File: .cursor/rules/dev.mdc:0-0
Timestamp: 2025-12-23T19:56:56.405Z
Learning: Mobile app (exactly/mobile) uses React Native, Expo, Tamagui (UI), Expo Router (navigation), and TanStack Query (state management)
Applied to files:
package.json
📚 Learning: 2025-12-23T19:57:22.339Z
Learnt from: CR
Repo: exactly/exa PR: 0
File: .cursor/rules/markdown.mdc:0-0
Timestamp: 2025-12-23T19:57:22.339Z
Learning: Applies to **/*.md : All lines in markdown files must be no longer than 120 characters
Applied to files:
CHANGELOG.md
🔇 Additional comments (1)
package.json (1)
3-3: LGTM! Version bump is correct.The patch version increment from 1.0.44 to 1.0.45 aligns with the release process for the installments fee feature.
cruzdanilo
force-pushed
the
changeset-release/main
branch
from
df848fd to
7c60eee
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI Agents
In @server/CHANGELOG.md:
- Around line 3-7: The changelog entry line "-
[#621](https://github.com/exactly/exa/pull/621)
[`fd9b7a8`](https://github.com/exactly/exa/commit/fd9b7a8fa8ee3373b2d518fbc2d5c934af2974d3)
Thanks [@mainqueg](https://github.com/mainqueg)! - ✅ use injected account
factory in tests" exceeds 120 characters; split it into two or more lines so no
line >120 chars, e.g., keep the pull request and commit reference on the first
line and move the contributor attribution and description to a subsequent
indented continuation line (use two spaces for list continuation) so the entry
remains a single list item but conforms to the markdown line-length rule.
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (5)
.changeset/big-carrots-design.mdCHANGELOG.mdpackage.jsonserver/CHANGELOG.mdserver/package.json
💤 Files with no reviewable changes (1)
- .changeset/big-carrots-design.md
🧰 Additional context used
📓 Path-based instructions (2)
**/*.md
📄 CodeRabbit inference engine (.cursor/rules/markdown.mdc)
**/*.md: Each markdown file must start with a single top-level heading (# heading 1)
Headings must be sequential (e.g.,#->##->###), do not skip levels
Do not end headings with punctuation (.,:,!,?)
Use a hyphen (-) for unordered list items in markdown
Sub-lists in markdown must be indented with a two-space offset
Always use unordered lists (-) instead of numbered lists (1.) in markdown
All code blocks must be fenced with backticks (```) and specify a language identifier
Useshor `bash` as the language identifier for shell commands in markdown code blocks
All code identifiers inside backticks or code fences must strictly follow casing rules defined in `style.mdc` (`camelCase` for variables, `PascalCase` for types, etc.)
All code comments must be lowercase
All lines in markdown files must be no longer than 120 characters
Surround all block-level elements (headings, lists, code blocks) with a single blank line in markdown
Do not add multiple consecutive blank lines in markdown files
No lines should have trailing whitespace in markdown files
Use asterisks (`word`) for italics and double asterisks (`word`) for bold in markdown
Provide descriptive titles for links in markdown instead of generic phrases like 'click here'Use proper sentence case for user-facing documentation in the
docs/directory
Files:
CHANGELOG.mdserver/CHANGELOG.md
**/*.{mdc,md}
📄 CodeRabbit inference engine (.cursor/rules/style.mdc)
**/*.{mdc,md}: All narrative text in internal documentation prose (headings, paragraphs, list items, proper nouns, brand names) must be lowercase with no exceptions
When discussing code concepts in prose, use regular lowercase words and place correctly-cased identifiers inside backticks
Any identifier inside backticks or code fences must strictly follow the casing rules defined in the style guide and be treated as code, not prose
Files:
CHANGELOG.mdserver/CHANGELOG.md
🧠 Learnings (3)
📚 Learning: 2025-12-23T19:56:56.405Z
Learnt from: CR
Repo: exactly/exa PR: 0
File: .cursor/rules/dev.mdc:0-0
Timestamp: 2025-12-23T19:56:56.405Z
Learning: Server (exactly/server) uses Hono (framework), Node.js, Drizzle ORM (database), and PostgreSQL
Applied to files:
server/package.json
📚 Learning: 2025-12-23T19:56:56.405Z
Learnt from: CR
Repo: exactly/exa PR: 0
File: .cursor/rules/dev.mdc:0-0
Timestamp: 2025-12-23T19:56:56.405Z
Learning: Mobile app (exactly/mobile) uses React Native, Expo, Tamagui (UI), Expo Router (navigation), and TanStack Query (state management)
Applied to files:
package.json
📚 Learning: 2026-01-05T21:07:34.094Z
Learnt from: franm91
Repo: exactly/exa PR: 614
File: package.json:94-94
Timestamp: 2026-01-05T21:07:34.094Z
Learning: For the exactly/exa mobile app, native module dependencies (like react-native-gesture-handler, react-native-reanimated, etc.) should use versions that match Expo SDK's bundledNativeModules.json to ensure compatibility and stability. Don't suggest upgrading these packages to latest npm versions if they're aligned with the Expo SDK version in use.
Applied to files:
package.json
🔇 Additional comments (2)
server/package.json (1)
3-3: Version bump is correct.The patch version update from 0.2.46 to 0.2.47 correctly reflects the release and aligns with the changelog entry for PR #621.
package.json (1)
3-3: LGTM! Version bump is consistent with release.The patch version bump to 1.0.45 aligns with the PR objectives and follows semantic versioning for the changes included (installments fee in payment details from PR #617).
cruzdanilo
force-pushed
the
changeset-release/main
branch
from
7c60eee to
93984e3
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
cruzdanilo
force-pushed
the
changeset-release/main
branch
from
93984e3 to
026a000
Compare
cruzdanilo
force-pushed
the
changeset-release/main
branch
from
026a000 to
0271876
Compare
cruzdanilo
had a problem deploying
to
production
GitHub Actions
Failure
1 participant
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@exactly/mobile@1.0.45
Patch Changes
#617
b3153b8Thanks @itofarina! - 🐛 include installments fee in payment detailsUpdated dependencies [
bfd960c]:@exactly/server@0.2.47
Patch Changes
bfd960cThanks @aguxez! - ✨ support pax assistanceSummary by CodeRabbit
New Features
Bug Fixes
✏️ Tip: You can customize this high-level summary in your review settings.