Skip to content

🤡 server: mock missing persona call#699

Merged
cruzdanilo merged 1 commit intomainfrom
flaky
Jan 30, 2026
Merged

🤡 server: mock missing persona call#699
cruzdanilo merged 1 commit intomainfrom
flaky

Conversation

@cruzdanilo
Copy link
Member

@cruzdanilo cruzdanilo commented Jan 30, 2026

attempt to fix test flakiness: https://github.com/exactly/exa/actions/runs/21517413458/job/61999184672


Open with Devin

Summary by CodeRabbit

  • Tests

    • Enhanced test coverage for account creation workflows.
  • Chores

    • Added changeset metadata file.

✏️ Tip: You can customize this high-level summary in your review settings.

@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2026

🦋 Changeset detected

Latest commit: bb36bfb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gemini-code-assist
Copy link

Summary of Changes

Hello @cruzdanilo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses test flakiness by adding a necessary mock for an external service call within a test file. The change ensures that the persona.addDocument function returns a predictable value, thereby stabilizing the test suite and preventing intermittent failures related to this dependency.

Highlights

  • Test Stability: A mock for the persona.addDocument call has been introduced in server/test/hooks/persona.test.ts to ensure consistent test execution and prevent flakiness.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai
Copy link

coderabbitai bot commented Jan 30, 2026

Walkthrough

Two minimal changes are introduced: a placeholder changeset file and a test update. The changeset file contains only YAML separators. The test for panda account creation now includes a mock for the persona.addDocument method to resolve with a dummy document ID.

Changes

Cohort / File(s) Summary
Changeset Files
.changeset/wise-cities-jam.md
Added placeholder changeset file with YAML document separators.
Test Updates
server/test/hooks/persona.test.ts
Added mock for persona.addDocument in panda account creation test to resolve with a dummy document ID.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

  • nfmelendez
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding a mock for a missing persona call to fix test flakiness, which aligns with the changeset modifications.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch flaky

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request effectively addresses test flakiness by introducing a mock for the persona.addDocument call within the creates a panda account test case. This change enhances the reliability and isolation of the test, ensuring it does not depend on external service availability and preventing intermittent failures. The review comments highlight this positive change.

Copy link

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional flags.

Open in Devin Review

@sentry
Copy link

sentry bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.73%. Comparing base (4380280) to head (bb36bfb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #699      +/-   ##
==========================================
+ Coverage   63.71%   63.73%   +0.01%     
==========================================
  Files         169      169              
  Lines        5324     5324              
  Branches     1501     1501              
==========================================
+ Hits         3392     3393       +1     
+ Misses       1745     1744       -1     
  Partials      187      187              
Flag Coverage Δ
e2e 42.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cruzdanilo cruzdanilo merged commit bb36bfb into main Jan 30, 2026
15 checks passed
@cruzdanilo cruzdanilo deleted the flaky branch January 30, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant