Skip to content

🥅 app: catch biometric error in passkey creation#753

Merged
cruzdanilo merged 1 commit intomainfrom
passkey
Feb 9, 2026
Merged

🥅 app: catch biometric error in passkey creation#753
cruzdanilo merged 1 commit intomainfrom
passkey

Conversation

@cruzdanilo
Copy link
Member

@cruzdanilo cruzdanilo commented Feb 9, 2026


Open with Devin

Summary by CodeRabbit

  • Bug Fixes

    • Improved error handling to better detect and communicate biometric authentication requirements during passkey operations.
  • Localization

    • Added comprehensive Spanish language support for biometric-related user messages.

@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2026

🦋 Changeset detected

Latest commit: 53f75e7

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gemini-code-assist
Copy link

Summary of Changes

Hello @cruzdanilo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the application's passkey creation flow by gracefully handling scenarios where biometrics are not enabled. It provides clear guidance to users encountering biometric errors, improving the overall user experience and reducing confusion during authentication setup.

Highlights

  • Biometric Error Handling: Introduced specific error handling for biometric failures during passkey creation, displaying a user-friendly message.
  • Internationalization: Added a new Spanish translation for the biometric error message to es.json.
Changelog
  • src/i18n/es.json
    • Added a new translation key and value for 'Biometrics must be enabled to use passkeys. Please enable biometrics in your device settings' in Spanish.
  • src/utils/useAuth.ts
    • Implemented a new error handling block within the handleError function to specifically catch errors with code 'ERR_BIOMETRIC'.
    • When a biometric error occurs, the authentication method is cleared, and a toast notification is displayed, instructing the user to enable biometrics.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai
Copy link

coderabbitai bot commented Feb 9, 2026

Warning

Rate limit exceeded

@cruzdanilo has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 27 minutes and 53 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch passkey

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sentry
Copy link

sentry bot commented Feb 9, 2026

Sentry Issue: EXA-1DT

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Este pull request mejora el manejo de errores para la autenticación biométrica, proporcionando un mensaje claro al usuario cuando la biometría no está habilitada. También incluye la traducción al español para este nuevo mensaje de error.

Copy link

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@sentry
Copy link

sentry bot commented Feb 9, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.29%. Comparing base (5f4b287) to head (53f75e7).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/utils/useAuth.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #753      +/-   ##
==========================================
- Coverage   67.74%   67.29%   -0.46%     
==========================================
  Files         206      206              
  Lines        6927     7005      +78     
  Branches     2169     2189      +20     
==========================================
+ Hits         4693     4714      +21     
- Misses       2045     2099      +54     
- Partials      189      192       +3     
Flag Coverage Δ
e2e 66.80% <0.00%> (+14.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cruzdanilo cruzdanilo merged commit 53f75e7 into main Feb 9, 2026
13 of 15 checks passed
@cruzdanilo cruzdanilo deleted the passkey branch February 9, 2026 21:29
@sentry
Copy link

sentry bot commented Feb 15, 2026

Sentry Issue: EXA-177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant