Conversation
|
No actionable comments were generated in the recent review. 🎉 WalkthroughThis PR removes three changeset entries and consolidates them into the CHANGELOG.md as version 1.1.17 for the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @cruzdanilo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates the release of the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request is an automated release for version 1.1.17 of the @exactly/mobile package. The changes correctly update package.json and CHANGELOG.md. I've added one comment on the changelog with a suggestion for a minor improvement in the implementation of one of the features included in this release, to be addressed in a follow-up. Otherwise, this PR is good to merge.
|
|
||
| ### Patch Changes | ||
|
|
||
| - [#795](https://github.com/exactly/exa/pull/795) [`1efacfa`](https://github.com/exactly/exa/commit/1efacfad5a2bb67c8944448cfff07e0bbedd5936) Thanks [@cruzdanilo](https://github.com/cruzdanilo)! - 🥅 handle biometric check before passkey fallback |
There was a problem hiding this comment.
Regarding the implementation for handle biometric check before passkey fallback, I noticed a potential improvement for type safety in src/utils/useAuth.ts at line 54. The check for error.code on an Error object is not fully type-safe, as code is not a standard property of Error.
To improve robustness and align with TypeScript best practices, I recommend using a type guard to check for the existence and type of the code property before accessing it. For example:
const hasCode = (error: unknown): error is { code: string } => {
return typeof error === 'object' && error !== null && 'code' in error;
};
// in handleError
if (error instanceof Error && hasCode(error) && error.code === 'ERR_BIOMETRIC') {
// ...
}This is a minor point and can be addressed in a follow-up PR, as the file is not part of this diff. It would make the error handling logic more resilient.
References
- Prefer refactoring for explicit type safety, even if it adds slight verbosity, as it prevents potential runtime errors and maintains type-checking integrity. This suggestion improves type safety when checking for custom error codes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #796 +/- ##
==========================================
+ Coverage 69.21% 69.76% +0.55%
==========================================
Files 208 208
Lines 7090 7471 +381
Branches 2255 2394 +139
==========================================
+ Hits 4907 5212 +305
- Misses 1999 2043 +44
- Partials 184 216 +32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@exactly/mobile@1.1.17
Patch Changes
#795
1efacfaThanks @cruzdanilo! - 🥅 handle biometric check before passkey fallback#795
861d30bThanks @cruzdanilo! - 🥅 fingerprint network errors#795
375ea92Thanks @cruzdanilo! - 🥅 suppress expected network errorsSummary by CodeRabbit