source_dir_purge not removing directories without force

[erik-smit]

I've noticed that "recurse => true, purge => true" on a file resource doesn't remove directories.
Only if you add "force => true" will it remove directories.

Currently, force isn't implemented in any modules, which causing problems for me.

What do you think would be the way to approach this?

a) Add a source_dir_force parameter.
b) Make source_dir_purge also set force on the source_dir resource.
c) Something else?

My preference goes to b.
The purge parameter clearly states the intention of the user to purge the contents of the directory.
Having to add yet another parameter to actually perform the request is counter-intuitive and confusing.

[alvagante]

Good point.
I followed your advice for point b:
8cc8707

Please let me know if this solution fits your case and feel free to pull requests for a similar patch on the modules you use.

[erik-smit]

This is exactly what I had in mind, thanks.