Fix modal closing unexpectedly during text selection #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user starts a drag operation inside the modal (e.g., selecting text in an input field) and their mouse moves outside the modal boundary, the modal closes unexpectedly when they release the mouse button. This happens because the browser fires a click event on the backdrop even when mousedown started inside the modal content. This fix checks if text is currently selected before closing. If the user has an active text selection, the modal stays open. Fixes excid3#278
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user starts a drag operation inside the modal (e.g., selecting text in an input field) and their mouse moves outside the modal boundary, the modal closes unexpectedly when they release the mouse button.
This happens because the browser fires a click event on the backdrop even when mousedown started inside the modal content.
This fix checks if text is currently selected before closing. If the user has an active text selection, the modal stays open.
Fixes #278