Skip to content

Conversation

@jarrodmillman
Copy link
Contributor

No description provided.

@welcome
Copy link

welcome bot commented Jun 8, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #422 (4af2215) into master (f2484fa) will increase coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
+ Coverage   81.21%   81.37%   +0.16%     
==========================================
  Files          29       29              
  Lines        2523     2551      +28     
==========================================
+ Hits         2049     2076      +27     
- Misses        474      475       +1     
Flag Coverage Δ
pytests 81.37% <ø> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
myst_nb/core/nb_to_tokens.py 94.23% <0.00%> (-1.85%) ⬇️
myst_nb/core/execute/base.py 97.70% <0.00%> (+0.14%) ⬆️
myst_nb/core/render.py 85.13% <0.00%> (+0.30%) ⬆️
myst_nb/docutils_.py 74.25% <0.00%> (+0.31%) ⬆️
myst_nb/core/variables.py 73.68% <0.00%> (+0.35%) ⬆️
myst_nb/core/read.py 83.88% <0.00%> (+0.36%) ⬆️
myst_nb/core/config.py 78.74% <0.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2484fa...4af2215. Read the comment docs.

Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM - py310 tests seem happy, and I don't know of any reason to suspect 3.10 wouldn't work, so I'm +1 !

I saw that you deleted the commented-out Sphinx 3 line...In my opinion that's OK since we weren't testing it anyway there, and Sphinx 5 is out now so I suspect we should focus our efforts on supporting that.

@chrisjsewell chrisjsewell changed the title Add Python 3.10 support ⬆️ UPGRADE: Add Python 3.10 support Jun 10, 2022
@chrisjsewell chrisjsewell merged commit 3560d1a into executablebooks:master Jun 10, 2022
@welcome
Copy link

welcome bot commented Jun 10, 2022

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@chrisjsewell
Copy link
Member

cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants