Skip to content

Conversation

@dprada
Copy link
Contributor

@dprada dprada commented Oct 3, 2022

Some lines were added to mystnb.css to add scroll bars with tags: 'output_scroll', 'scroll-output' and 'scroll-input'.

The lines implemented are similar to the paragraph in https://github.com/executablebooks/sphinx-book-theme/blob/eb1b6baf098b27605e8f2b7b2979b17ebf1b9540/src/sphinx_book_theme/assets/styles/extensions/_myst-nb.scss#L21. The only difference is the inclusion of indications for horizontal bars (width and y lines).

See #453

@welcome
Copy link

welcome bot commented Oct 3, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.63%. Comparing base (385c4a7) to head (0e94fca).
Report is 94 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #454      +/-   ##
==========================================
- Coverage   81.67%   81.63%   -0.04%     
==========================================
  Files          29       29              
  Lines        2647     2647              
==========================================
- Hits         2162     2161       -1     
- Misses        485      486       +1     
Flag Coverage Δ
pytests 81.63% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @dprada have a look at my comment for changes

@dprada dprada requested a review from chrisjsewell October 5, 2022 16:49
Copy link
Contributor Author

@dprada dprada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already solved, right?

@bsipocz bsipocz changed the title Adding scroll bars with proper cell tags BUG: Adding scroll bars with proper cell tags Nov 26, 2024
@bsipocz bsipocz added the bug Something isn't working label Nov 26, 2024
@bsipocz bsipocz added enhancement New feature or request and removed bug Something isn't working labels Apr 24, 2025
@bsipocz bsipocz changed the title BUG: Adding scroll bars with proper cell tags ENH: Adding scroll bars with proper cell tags Apr 24, 2025
Copy link
Collaborator

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous review comments have been addressed, and I've read through the xreffed discussions and think this should be a go ahead.

Thanks @dprada!

@bsipocz bsipocz dismissed chrisjsewell’s stale review April 25, 2025 16:32

The review comments have been addressed.

@bsipocz bsipocz merged commit 4b7a0ed into executablebooks:master Apr 25, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants