Skip to content

Conversation

@je-cook
Copy link
Contributor

@je-cook je-cook commented Aug 30, 2023

Hi,

This PR should fix the failing CI for sphinx 7 which adds translation metadata to some of the outputs.

I've patched the file_regression comparison fixture to strip out the differences between sphinx<7 and 7. Hopefully this will allow the merge of #532 #533 and #534 and is maybe enough for a new release as requested in #530.

Thanks!

@welcome
Copy link

welcome bot commented Aug 30, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@agoose77
Copy link
Collaborator

Thanks for this! It looks correct to me, so we'll merge and see what happens ;)

@agoose77 agoose77 merged commit 540b756 into executablebooks:master Sep 18, 2023
@welcome
Copy link

welcome bot commented Sep 18, 2023

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@PhilipVinc
Copy link

@agoose77 thanks for merging this! I hate to nag you but if in the next 30 minutes or so tests pass, could you please tag a new release (closing #530 )? This will allow to tag new releases on a large set of packages which were stuck on older sphinx versions...

Thanks for the hard work!

@agoose77
Copy link
Collaborator

It's my intention to do that, but first I'm going to get our CI passing :)

@je-cook je-cook deleted the fix_CI branch September 18, 2023 09:36
@agoose77 agoose77 changed the title Patch file_regression fixture for sphinx backwards compatibility MAINT: Patch file_regression fixture for Sphinx backwards compatibility Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants