Skip to content

Conversation

@flokli
Copy link

@flokli flokli commented Aug 4, 2022

Update the version bounds to allow docutils 0.19, and update the
fixtures to match the output produced by 0.19.

Fixes #591.

Update the version bounds to allow docutils 0.19, and update the
fixtures to match the output produced by 0.19.
@welcome
Copy link

welcome bot commented Aug 4, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@flokli
Copy link
Author

flokli commented Aug 4, 2022

As written in #591 (comment), this now bumps the required version to 0.19. I'm not sure how to conditionally update the fixture contents to the output docutils 0.19 presents, only when docutils >0.19 is available.

I've seen a similar PR at #478 that patches the fixtures, but it looks like it's not patched conditionally. Did the tests with older versions just fail?

@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #606 (aa31ec6) into master (7556122) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #606      +/-   ##
==========================================
- Coverage   89.86%   89.77%   -0.10%     
==========================================
  Files          21       21              
  Lines        2122     2122              
==========================================
- Hits         1907     1905       -2     
- Misses        215      217       +2     
Flag Coverage Δ
pytests 89.77% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
myst_parser/mocking.py 86.27% <0.00%> (-0.79%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ssbarnea
Copy link

@flokli Any chance you could bring this PR to a form that could be merged? ... as in passing CI.

I am sure lots of us want to upgrade docutils, even if it might prove to be better to find a solution that does not drop support for older versions, as it is likely to cause impossible to address dependency conflicts with other docutils consumers.

@flokli
Copy link
Author

flokli commented Aug 15, 2022

This PR was mostly intended to show what has changed with later versions of docutils. I still need some feedback from maintainers on how to proceed with this, as written in #606 (comment).

@chrisjsewell
Copy link
Member

superceded by #611

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please test with Docutils 0.19b1

3 participants