Skip to content

Conversation

@sumezulike
Copy link
Contributor

@sumezulike sumezulike commented Mar 11, 2024

Adds emission of Sphinx include-read events while processing include directives, closes #881.

include-read

If there is a better way to restrict the test to Sphinx>=7.5.2, please let me know.

@welcome
Copy link

welcome bot commented Mar 11, 2024

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@sumezulike sumezulike force-pushed the emit-input-read-event branch from a81a9a3 to 4f4624d Compare March 11, 2024 18:23
…thon 3.12

Also added test for included files that are not inside the source directory
@sumezulike
Copy link
Contributor Author

Sorry about the noise, I forgot to test against older Python versions. Grateful for any feedback!

@chrisjsewell
Copy link
Member

cheers will have a look soon

@sumezulike
Copy link
Contributor Author

Any chance to take a look yet?

@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.12%. Comparing base (da1a85a) to head (d0bddee).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #887      +/-   ##
==========================================
+ Coverage   90.10%   90.12%   +0.01%     
==========================================
  Files          24       24              
  Lines        3377     3383       +6     
==========================================
+ Hits         3043     3049       +6     
  Misses        334      334              
Flag Coverage Δ
pytests 90.12% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisjsewell
Copy link
Member

If there is a better way to restrict the test to Sphinx>=7.5.2, please let me know.

sorted

Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good thanks!

@chrisjsewell chrisjsewell merged commit 961a638 into executablebooks:master Mar 26, 2024
@welcome
Copy link

welcome bot commented Mar 26, 2024

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@sumezulike
Copy link
Contributor Author

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Emit include-read event

3 participants