Skip to content

👌 IMPROVE: Use mdformat-footnote#19

Merged
chrisjsewell merged 1 commit intomasterfrom
footnote-dep
Feb 21, 2022
Merged

👌 IMPROVE: Use mdformat-footnote#19
chrisjsewell merged 1 commit intomasterfrom
footnote-dep

Conversation

@hukkin
Copy link
Collaborator

@hukkin hukkin commented Feb 16, 2022

Closes #15

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #19 (9550e98) into master (3d47f3c) will decrease coverage by 0.63%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   92.94%   92.30%   -0.64%     
==========================================
  Files           3        3              
  Lines         170      156      -14     
==========================================
- Hits          158      144      -14     
  Misses         12       12              
Flag Coverage Δ
pytests 92.30% <100.00%> (-0.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mdformat_myst/plugin.py 97.01% <100.00%> (-0.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d47f3c...9550e98. Read the comment docs.

@hukkin hukkin requested a review from chrisjsewell February 16, 2022 09:37
# Enable footnote markdown-it extension
mdit.use(footnote_plugin)
# MyST has inline footnotes disabled
mdit.disable("footnote_inline")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of interest, does mdformat-footnote have footnote_inline enabled?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use mdformat-footnote

2 participants