Skip to content

Change admonition title CSS specificity#111

Merged
mmcky merged 1 commit intomainfrom
admonition-style-update
Sep 8, 2024
Merged

Change admonition title CSS specificity#111
mmcky merged 1 commit intomainfrom
admonition-style-update

Conversation

@DrDrij
Copy link
Copy Markdown
Collaborator

@DrDrij DrDrij commented Jul 29, 2024

This CSS tweak adjusts the styling so that styles can be overriden without having to be forced.

They will cascade from py_data -> quantecon_book_theme -> sphinx_proof.

QuantEcon/lecture-python-intro#493

This CSS tweak adjust the styling so that styles can be overriden without having to be forced. 

They will cascade from py_data -> quantecon_book_theme -> sphinx_proof.

QuantEcon/lecture-python-intro#493
@mmcky
Copy link
Copy Markdown
Member

mmcky commented Aug 20, 2024

thanks @DrDrij I will run some tests on this branch now. Greatly appreciate your work on this.

@mmcky
Copy link
Copy Markdown
Member

mmcky commented Aug 20, 2024

@DrDrij just to confirm. This change will mean these styles still work outside of the context of using jointly with quantecon-book-theme? It just defines a tighter hierarchy for the style. Is that right?

@DrDrij
Copy link
Copy Markdown
Collaborator Author

DrDrij commented Aug 20, 2024

@mmcky Precisely. It looks from my changes like any element that isn't <p> is now targeted, but it still styles all existing markup in the same way. It just allows us to latch on to these groups of styles in a simpler way. 🙂

@mmcky
Copy link
Copy Markdown
Member

mmcky commented Sep 8, 2024

thanks @DrDrij

@mmcky mmcky merged commit 946965a into main Sep 8, 2024
@mmcky mmcky deleted the admonition-style-update branch September 8, 2024 23:44
@mmcky mmcky mentioned this pull request Sep 8, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants