Make Tabs collapsible #73
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaSa1002
commented
Jul 22, 2020
HaSa1002
commented
|
Is there any interest in this PR? We want to use it for https://github.com/godotengine/godot-docs and would prefer not to have to maintain a fork with custom changes if we can avoid it. |
Collaborator
|
Hey @akien-mga and @HaSa1002, the latest release (v2.0.0) includes a rewrite of the extension's JS. I've included an equivalent to this improvement in that release, please could you let me know if it works as expected? |
Author
|
@foster999 I did a quick build of said repo and it appears to work fine. |
Collaborator
|
Great, thanks for checking! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.