This repository was archived by the owner on Aug 1, 2021. It is now read-only.
Remove test which allows degenerate (a+b=c) triangles#164
Merged
matthewmorgan merged 1 commit intomasterfrom Feb 25, 2016
Merged
Remove test which allows degenerate (a+b=c) triangles#164matthewmorgan merged 1 commit intomasterfrom
matthewmorgan merged 1 commit intomasterfrom
Conversation
Contributor
|
Yeah! I'll merge this as soon as I have some time. Feel free to merge yourself if you want @matthewmorgan. What about xecmascript? Is there the same case there? |
Contributor
Author
|
Yes there is, bc yours truly made the same change on that track! I'm about to push a fix, then I thought I'd add @mikegee's new test in a separate PR, OK? |
Contributor
Author
|
For some reason the Travis build isn't starting to run...Oops. there it goes. |
matthewmorgan
added a commit
that referenced
this pull request
Feb 25, 2016
Remove test which allows degenerate (a+b=c) triangles
Contributor
|
Thanks so much for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm removing this test that i added after the outcome of a discussion on the Erlang track that concluded we should not allow 'degenerate' triangles, EG sides a,c,b where a+b=c.