Skip to content
This repository was archived by the owner on Aug 1, 2021. It is now read-only.

Reverse string#419

Closed
eliaahadi wants to merge 2 commits intoexercism:masterfrom
eliaahadi:reverse-string
Closed

Reverse string#419
eliaahadi wants to merge 2 commits intoexercism:masterfrom
eliaahadi:reverse-string

Conversation

@eliaahadi
Copy link
Copy Markdown
Contributor

updated folder

@matthewmorgan
Copy link
Copy Markdown
Contributor

@eliaahadi thanks so much for your effort! I need to figure out how best to approach this PR, because this exercise appears to be entirely new to exercism.

I believe that the usual approach to adding a new exercise to exercism would be to open a request in the https://github.com/exercism/problem-specifications repo, and after that is merged, it can be implemented in specific languages.

@rchavarria can you comment on this?

I am also wondering if it is OK for us to implement an exercise attributed to an external author-- what permissions do we need @kytrinyx ?

Let's get these questions answered and then we can figure out the best way to proceed.

@eliaahadi
Copy link
Copy Markdown
Contributor Author

Thanks good to know. Perhaps after we finally implement this, I can write step by step tutorial on how to do this from scratch to PR, it'd be helpful for me and others I'd think. The github PR I'm certainly still new at too.

@eliaahadi
Copy link
Copy Markdown
Contributor Author

Hi I'm not exactly sure what's failing or perhaps you didn't have time to review this commit, any thoughts on how to move forward with this PR? Thank you.

@matthewmorgan
Copy link
Copy Markdown
Contributor

@eliaahadi it looks like this and #417 are a PR for the same exercise. Please see my comments there further explaining the process.

@eliaahadi
Copy link
Copy Markdown
Contributor Author

this is a duplicate of #417

@eliaahadi eliaahadi closed this Oct 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants