Skip to content

reverse-string: add test that exposes unquoted variable problems#397

Merged
glennj merged 1 commit intoexercism:masterfrom
glennj:reverse-string-add-globbing-test
Oct 3, 2019
Merged

reverse-string: add test that exposes unquoted variable problems#397
glennj merged 1 commit intoexercism:masterfrom
glennj:reverse-string-add-globbing-test

Conversation

@glennj
Copy link
Copy Markdown
Contributor

@glennj glennj commented Oct 3, 2019

Addressing same problem as PR #377


Reviewer Resources:

Track Policies

@guygastineau
Copy link
Copy Markdown
Contributor

Is this our own test? (ie. not from problem-specifications)

@glennj
Copy link
Copy Markdown
Contributor Author

glennj commented Oct 3, 2019

Is this our own test? (ie. not from problem-specifications)

Yes. It comes from seeing the same mistake over and over while mentoring.

I would not think this kind of problem exists in other languages, so I don't think it's worth submitting to the canonical data.

Copy link
Copy Markdown
Member

@IsaacG IsaacG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@glennj glennj merged commit 949e743 into exercism:master Oct 3, 2019
@glennj glennj deleted the reverse-string-add-globbing-test branch October 3, 2019 21:48
@guygastineau
Copy link
Copy Markdown
Contributor

Right, but we don't get to increment the version past the canonical-data version I don't believe

@guygastineau
Copy link
Copy Markdown
Contributor

The Dashboard doesn't seem to care, but what happens if the canonical-data.json is upgraded? We wont be able to tell that our exercise is behind the new information in the problem-specifications repository.

@guygastineau
Copy link
Copy Markdown
Contributor

BTW, sorry I didn't see your response earlier. For the record I think this is a great test to add to this exercise for our track! 🤓

@glennj
Copy link
Copy Markdown
Contributor Author

glennj commented Oct 4, 2019

I've done it before, see https://tracks.exercism.io/bash/master (word-count, for example) -- the major and minor versions are the same, just the patch number is incremented.

@guygastineau
Copy link
Copy Markdown
Contributor

Right, sometimes test semantics are changed and they just increment the patch number, so we will still be getting out of sync.

Unless I am missing something here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants