Skip to content

Add eliuds eggs#79

Open
nastamattina wants to merge 14 commits intoexercism:mainfrom
nastamattina:add-eliuds-eggs
Open

Add eliuds eggs#79
nastamattina wants to merge 14 commits intoexercism:mainfrom
nastamattina:add-eliuds-eggs

Conversation

@nastamattina
Copy link

Hi, this time I got started using configlet and so I hope this is ground-up correct. Tested in cmd 10.0.26200.7623 on a Win11 virtual machine.

@github-actions
Copy link

Hello 👋 Thanks for your PR.

This repo does not currently have dedicated maintainers. Our cross-track maintainers team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed.

If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track.

Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum.

(cc @exercism/cross-track-maintainers)

},
{
"slug": "eliuds-eggs",
"name": "Eliuds Eggs",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The canonical exercise name is Eliud's Eggs. It looks like the CI uses the name rather than the slug, which is causing the original issue. The appropriate thing to do here is likely have the CI directly convert the slug to Pascal Case. There's at least one practice exercise where the slug and title won't match. You don't necessarily have to make the CI change here, but this is something for the maintainer to consider.

"slug": "eliuds-eggs",
"name": "Eliuds Eggs",
"uuid": "0875c5f0-8336-494b-b32a-b9d789d32ea7",
"practices": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

practices should be an array of existing concept slugs. I don't believe any of these three exist.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bitwise isn't so I removed it, but loops, numbers, and basics are, or so it seems

"bitwise-operations",
"loops",
],
"prerequisites": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prerequisites should be an array of existing concept slugs that need to be unlocked before you can do this exercise in learning mode. This track doesn't have a learning mode so this section doesn't really need to be populated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants