Skip to content

nucleotide-count: Remove special treatment of uracil #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kytrinyx merged 1 commit into from
Aug 21, 2014
Merged

nucleotide-count: Remove special treatment of uracil #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nucleotide-count/example.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ class DNA
G: @value 'G'

value: (nucleotide) ->
if nucleotide is 'U' then 0 else @strand.split(nucleotide).length - 1
@strand.split(nucleotide).length - 1

count: (nucleotide) ->
throw new Error('Invalid Nucleotide') if nucleotide not of @nucleotideCounts
Expand Down
4 changes: 0 additions & 4 deletions nucleotide-count/nucleotide-count_test.spec.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,6 @@ describe 'DNA', ->
dna.count('T')
expect(dna.count('T')).toEqual 2

xit 'has no uracil', ->
dna = new DNA('GGTTGG')
expect(dna.value('U')).toEqual 0

xit 'validates nucleotides', ->
dna = new DNA('GGTTGG')
expect ->
Expand Down