Skip to content

Included posix_time header in test. Changed Example accordingly (#149). #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lkskstlr wants to merge 1 commit into from
Closed

Included posix_time header in test. Changed Example accordingly (#149). #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions exercises/gigasecond/example.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#include "gigasecond.h"
#include "boost/date_time/posix_time/posix_time_types.hpp"

namespace gigasecond
{
Expand Down
4 changes: 3 additions & 1 deletion exercises/gigasecond/example.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
#if !defined(GIGASECOND_H)
#define GIGASECOND_H

#include <boost/date_time/posix_time/posix_time.hpp>
Copy link
Copy Markdown
Contributor

@arcuru arcuru Sep 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really shouldn't bother removing this here. It doesn't save anything since it always must be included to use this header anyways.

Yes it might be against some companies guidelines, but we're going for simplicity here instead of strictly following some definition of best practice. These tests just aren't going to do much to help teach best practices on a large Cpp codebase.

namespace boost{ namespace posix_time{
class ptime;
} }

namespace gigasecond
{
Expand Down
1 change: 1 addition & 0 deletions exercises/gigasecond/gigasecond_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#include "gigasecond.h"
#define BOOST_TEST_MAIN
#include <boost/date_time/posix_time/posix_time.hpp>
#include <boost/test/unit_test.hpp>

// See <http://www.boost.org/doc/libs/1_59_0/doc/html/date_time/posix_time.html>
Expand Down