Improve robot-name tests and remove Boost.Regex dependency.#156
Closed
arcuru wants to merge 3 commits intoexercism:masterfrom
Closed
Improve robot-name tests and remove Boost.Regex dependency.#156arcuru wants to merge 3 commits intoexercism:masterfrom
arcuru wants to merge 3 commits intoexercism:masterfrom
Conversation
arcuru
force-pushed
the
remove_regex
branch
3 times, most recently
from
cb70bbd to
31d5c51
Compare
Contributor
Author
|
Closing in deference to #159, which includes this change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the tests for robot-name (making sure that it can generate at least 1000 unique robot names), and transition to
std::regexinstead of Boost.Regex.The use of Boost.Regex only existed because GCC hadn't instituted
std::regexsupport at the time of original writing.