Including needed boost::posix_time.h#201
Merged
arcuru merged 1 commit intoexercism:masterfrom Aug 24, 2018
Merged
Conversation
Contributor
|
This has come up before in #142. The missing header is by design, you need to include it in your header file anyways to pick up the appropriate types. Thanks |
Contributor
|
Nvm, after looking at how many open issues we have around this I've changed my mind. I've been against this in the past (since you have to put in real effort to write an implementation that actually needs this include in the test suite), but given how many issues we've seen with people hitting initial compile problems with Thanks |
This was referenced Aug 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm getting a compiler error when trying the gigasecond exercise.
The library needed for posit_time was missing.
Please check the boost documentations: http://www.boost.org/doc/libs/1_59_0/doc/html/date_time/posix_time.html