Separate Catch Object#271
Merged
arcuru merged 2 commits intoexercism:masterfrom Apr 21, 2019
Merged
Conversation
Closed
Contributor
|
Looks reasonable. Fixes the user experience first in a straightforward fashion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a separate compilation object for the Catch main configuration. See https://github.com/catchorg/Catch2/blob/master/docs/slow-compiles.md for an explanation from Catch.
In short, including the Catch header is relatively heavy but not too bad, but most of the compilation time for Catch comes from compiling it with support for main, as that actually causes a compile of the Catch functionality and not just of the interface. By separating this out into it's own object, we ensure that students only need to build the object once per exercise, rather than every time they modify the test.cpp file or their exercise header. This was discussed in the comments of #233.
This also revealed an issue of a missing include in the clock test, which is fixed here.
This was done with the following script: