Implement armstrong numbers#285
Merged
arcuru merged 6 commits intoexercism:masterfrom Jun 4, 2019
Merged
Conversation
arcuru
suggested changes
Jun 1, 2019
Contributor
arcuru
left a comment
arcuru
left a comment
There was a problem hiding this comment.
Thanks for linking to the problem-specifications. That is really helpful, I should probably add that to the README.
Your example solution is interesting, and I mean that in a good way. It's not what I would have done, and if this were a real codebase I would probably suggest that you remove the static_cast<bool> trick in favor of explicit if checks so it's clearer to future readers, but it is pretty neat. (To be clear, I'm NOT asking you to change it, just commenting on it.)
Contributor
Author
|
@patricksjackson thank you for your time! I've made changes based on your suggestions. |
smuroff
force-pushed
the
implement_armstrong_numbers
branch
2 times, most recently
from
6220271 to
ea83bae
Compare
smuroff
force-pushed
the
implement_armstrong_numbers
branch
from
ea83bae to
394cb2e
Compare
arcuru
approved these changes
Jun 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
Ported armstrong-numbers exercise to C++.