queen-attack is missing tests (and example implementation) for the other diagonal#42
Merged
LegalizeAdulthood merged 2 commits intoexercism:masterfrom May 27, 2015
siebenschlaefer:master
Merged
queen-attack is missing tests (and example implementation) for the other diagonal#42LegalizeAdulthood merged 2 commits intoexercism:masterfrom siebenschlaefer:master
LegalizeAdulthood merged 2 commits intoexercism:masterfrom
siebenschlaefer:master
Conversation
Contributor
|
Thanks for the additon! I mimiced the JavaScript test cases; does the example JavaScript solution also suffer from the same problem? |
Contributor
Author
|
@LegalizeAdulthood Yes it does. It only tests cases where |
LegalizeAdulthood
added a commit
that referenced
this pull request
May 27, 2015
queen-attack is missing tests (and example implementation) for the other diagonal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unit tests and the example implementation test the north-west / south-east diagonal, but are missing the north-east / south-west diagonal.
Also there is no test case where the queens are not attacking each other.