chore: update github ci tools to ubuntu 22.04 #965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahans
approved these changes
May 6, 2025
Contributor
ahans
left a comment
ahans
left a comment
There was a problem hiding this comment.
While this will most certainly work, maybe we can drop the extra install steps?
.github/workflows/ci.yml
Outdated
| # Boost must be installed only because the CMake version (3.12) can't | ||
| # detect the installed Boost version (1.69) | ||
| run: sudo apt-get update && sudo apt-get -y install ninja-build libboost-date-time-dev clang-6.0 g++-10 g++-multilib | ||
| run: sudo apt-get update && sudo apt-get -y install ninja-build libboost-date-time-dev clang-15 g++-12 g++-multilib |
Contributor
There was a problem hiding this comment.
Have you checked that this is still really necessary? At least clang and gcc are part of the standard image.
Contributor
Author
There was a problem hiding this comment.
I wonder if we need multilib
ahans
reviewed
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubuntu 20.04 LTS support is going to stop this May.
Pipeline already stopped working.